"Rollout and activate" action #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiakchilo
approved these changes
Jul 29, 2024
| status.setSuccess(false); | ||
| LOG.error("Exception during page replication", ex); | ||
| } | ||
| status.setSuccess(true); |
There was a problem hiding this comment.
❗ Need to move this inside try, or else the status success will be reset to "true" after set to "false"
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
AlKaliada
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to rollout and publish selected page in one click has been implemented. By means of an additional parameter in the request - shouldActivate. The servlet understands whether the page should be activated or not. A new service has been added that, in a multi-threaded pool, calls page replication if necessary.