Implementing v1 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator, add progressbar to CLI Further improvements are improved state file handling, retrying HTTP requests in case retrieving the body fails and many more...
…is causes no slowdown), not when exporting (where it causes massive slowdown)
…throughput penalties
…nt syncing and querying
obitech
reviewed
Feb 17, 2024
|
I did not necessarily suggest to not include documentation in this PR - I just didn't want to do it before getting a second opinion on the API 🙃 But now that you took a look I will add some documentation. |
|
Documentation has been added. PTAL :) |
|
@obitech Might you please take another look? :) |
obitech
reviewed
Feb 29, 2024
obitech
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉
When agreeing on the general architecture I will add doc strings and a README :)