refactor: query should not return lines being prefixed with the k-pro… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianLoch
force-pushed
the
floch/fix-query-result-containing-prefix
branch
2 times, most recently
from
18c0ff9
to
0871c7d
Compare
…ximity range in order to mimick upstream API
FlorianLoch
force-pushed
the
floch/fix-query-result-containing-prefix
branch
from
0871c7d
to
7ae0dbc
Compare
…oes, and update tests accordingly
FlorianLoch
force-pushed
the
floch/fix-query-result-containing-prefix
branch
from
801c6bb
to
5825cb6
Compare
FlorianLoch
merged commit 136faa8
into
rework-api-to-allow-concurrent-updating-and-querying
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug resulting in unexpected output.
The upstream API does not prefix the lines with k-proximity range/prefix.
So this library should stick to that.