feat: allow functionally generated span names #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obitech
requested changes
May 15, 2023
|
We'll also need to bump https://github.com/exaring/otelpgx/blob/main/internal/constants.go#L10 to |
costela
reviewed
May 15, 2023
obitech
approved these changes
May 16, 2023
costela
approved these changes
May 16, 2023
|
LGTM! Thanks for the work! 👍 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will allow users to functionally decide how to create span names.
Take this example. This is the way sqlc forces you to annotate all your queries. It would be very this if the package could use this annotation.
Allowing users to write a function that extracts the span name from the query statement would enable the user to name the span
ListAuthors :manyas an example instead of, in this case,--with the default implementation.