build: Add cross-env for platform independent build #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ad1992
reviewed
Oct 9, 2023
.gitignore
Outdated
| @@ -25,3 +25,4 @@ | |||
| npm-debug.log* | |||
| yarn-debug.log* | |||
| yarn-error.log* | |||
| yarn.lock | |||
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ad1992
reviewed
Oct 9, 2023
ad1992
requested changes
Oct 9, 2023
package.json
Outdated
| "test:code": "eslint --max-warnings=0 --ext .js,.ts,.tsx ." | ||
| }, | ||
| "dependencies": { | ||
| "@excalidraw/markdown-to-text": "0.1.2", | ||
| "mermaid": "10.2.3", | ||
| "nanoid": "4.0.2" | ||
| "nanoid": "4.0.2", | ||
| "cross-env": "^7.0.3" |
There was a problem hiding this comment.
Suggested change
| "cross-env": "^7.0.3" | |
| "cross-env": "7.0.3" |
lets lock the exact version so everyone has exact same build when developing
package.json
Outdated
| @@ -40,7 +41,8 @@ | |||
| "parcel": "2.9.1", | |||
| "prettier": "2.8.8", | |||
| "process": "0.11.10", | |||
| "typescript": "5.2.2" | |||
| "typescript": "5.2.2", | |||
| "rimraf": "^5.0.5" | |||
There was a problem hiding this comment.
Suggested change
| "rimraf": "^5.0.5" | |
| "rimraf": "5.0.5" |
lets lock the exact version so everyone has exact same build when developing
ad1992
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current configuration does not build on windows. With these changes it does.