feat: add support for a open link #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielduete
approved these changes
Apr 10, 2024
ad1992
requested changes
Apr 11, 2024
There was a problem hiding this comment.
@igorwessel thank you for the contribution.
Could you make the 👇🏻 changes ?
- Could you give descriptive names for the test case similar to how its in https://github.com/excalidraw/mermaid-to-excalidraw/blob/master/playground/testcases/sequence.ts ?
- Also update the Changelog.md
igorwessel
force-pushed
the
feat/support-for-links-without-arrowhead
branch
from
78e0787
to
9be28da
Compare
@ad1992 I've applied the same format to all the flowchart tests. Could you take a look when you get a chance? I wasn't sure about the last ones, so I labeled them as 'Complex' for now. |
ad1992
requested changes
Apr 12, 2024
ad1992
reviewed
Apr 12, 2024
ad1992
reviewed
Apr 12, 2024
ad1992
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Looks great! Pushed some minor tweaks.
Thanks @igorwessel ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes excalidraw/excalidraw#7872
Closes #40
Mermaid provides a synyax to represent a link without arrow head.
flowchart LR A --- BThis Pull Request intends to introduce a feature that removes arrow heads when a specific syntax is encountered.
Test Cases