DOCS: Fix broken pytest fixture #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
peytondmurray
force-pushed
the
fix-ci
branch
from
a5e91ee
to
21c3666
Compare
agoose77
reviewed
Sep 26, 2023
agoose77
reviewed
Sep 26, 2023
| # TODO: Remove when support for Sphinx<=6 is dropped, | ||
| re.escape(" translation_progress=\"{'total': 0, 'translated': 0}\""), | ||
| # TODO: Remove when support for Sphinx<7.2 is dropped, | ||
| r"original_uri=\"[^\"]*\"\s", |
There was a problem hiding this comment.
This is a hack. But, I don't think it's the end of the world.
for more information, see https://pre-commit.ci
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
agoose77
approved these changes
Sep 26, 2023
|
Congrats on your first merged pull request in this project! 🎉 |
|
Thanks so much for the support getting this merged! |
agoose77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an instance where a
myst-nbtest fixture was using a test fixture that was previously provided by sphinx but was removed sometime between the release of6.2.1and7.2.6. Closes #545. This should also unblock a new release.Changes
tempdirfixture forpytest'stmpdirfixture as a drop-in replacement.