Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: test wider matrix #552

Merged
merged 19 commits into from
Oct 25, 2023
Merged

MAINT: test wider matrix #552

merged 19 commits into from
Oct 25, 2023

Conversation

agoose77
Copy link
Collaborator

This PR updates our CI to check Python 3.12, and varies myst-parser

@agoose77 agoose77 force-pushed the agoose77/ci-test-wider-matrix branch from a9bea3b to 463e999 Compare October 13, 2023 12:46
@agoose77
Copy link
Collaborator Author

Let me cut down the number of jobs, slightly.

@agoose77 agoose77 force-pushed the agoose77/ci-test-wider-matrix branch from e14ea90 to 4812d8d Compare October 13, 2023 13:02
choldgraf
choldgraf previously approved these changes Oct 13, 2023
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 - the changes LGTM though note there are some failing tests. I hit approve and leave it to your judgment whether it's right to merge

@michaelweinold
Copy link
Contributor

Would

df.a = [r'$\delta$','x','y']

instead of the current

df.a = [$\delta$','x','y']

mitigate the error, @agoose77? Curious that it fails only for some of the tests from the matrix.

michaelweinold and others added 4 commits October 25, 2023 10:53
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.291 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.291...v0.0.292)
- [github.com/pre-commit/mirrors-mypy: v1.5.1 → v1.6.0](pre-commit/mirrors-mypy@v1.5.1...v1.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Angus Hollands <[email protected]>
updates:
- [github.com/psf/black: 23.9.1 → 23.10.0](psf/black@23.9.1...23.10.0)
- [github.com/astral-sh/ruff-pre-commit: v0.0.292 → v0.1.1](astral-sh/ruff-pre-commit@v0.0.292...v0.1.1)
- [github.com/pre-commit/mirrors-mypy: v1.6.0 → v1.6.1](pre-commit/mirrors-mypy@v1.6.0...v1.6.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@agoose77 agoose77 force-pushed the agoose77/ci-test-wider-matrix branch from 788fdb8 to c4030ac Compare October 25, 2023 11:36
@michaelweinold
Copy link
Contributor

Relevant line from the readthedocs build:

WARNING: The default value for `navigation_with_keys` will change to `False` in the next release.
If you wish to preserve the old behavior for your site, set `navigation_with_keys=True` in the `html_theme_options` dict in your `conf.py` file.
Be aware that `navigation_with_keys = True` has negative accessibility implications:https://github.com/pydata/pydata-sphinx-theme/issues/1492

@agoose77
Copy link
Collaborator Author

Would

df.a = [r'$\delta$','x','y']

instead of the current

df.a = [$\delta$','x','y']

mitigate the error, @agoose77? Curious that it fails only for some of the tests from the matrix.

This is the fix that I've ultimately chosen, thanks @michaelweinold — I was also thinking of using a non-escaped character. I wasn't sure why docutils fails to escape this properly before I realised that it's being escaped in JSON, not in Python.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@michaelweinold
Copy link
Contributor

Well, well, well - the tests look great! Glad I could help with #552 (comment). Could we get another review by @choldgraf, perhaps? I believe everyone in #543 is eager for a new release.

@agoose77 agoose77 merged commit fd1fc66 into master Oct 25, 2023
16 checks passed
@agoose77 agoose77 changed the title ci: test wider matrix MAINT: test wider matrix Nov 29, 2023
@bsipocz bsipocz deleted the agoose77/ci-test-wider-matrix branch September 25, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants