MAINT: fix sphinx 8.0 compatibility #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, well, this was naive 😅 (but was passing locally) |
|
@bsipocz thanks for this, LGTM! I'll auto-merge and then see where we get to. |
|
@agoose77 - Thanks! As I see it still needs an actual review approval for the auto merge to kick in. |
czgdp1807
reviewed
Aug 29, 2024
This was referenced Aug 30, 2024
|
Thanks a lot for this PR! Could a new release be tagged which includes this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's beyond the scope for this PR, but I would also suggest adding a job that pulls the development versions of dependencies, even if it's just in a job that runs from a e.g. weekly cron; so end users would not run into incompatibilities when an upstream release is out.
(We do this for sphinx extensions and pytest plugins; as well as for libraries that more and more test against nightly wheels; and it's really nice from the release manager perspective as it removes a lot of cases for a rushed compatibility release).
Closes #619