Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amsmath and admonition container parsing #201

Merged
merged 6 commits into from
Aug 12, 2020
Merged

Conversation

chrisjsewell
Copy link
Member

No description provided.

Parser configuration options are now set as separate variables, rather than a single dict
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #201 into master will decrease coverage by 0.55%.
The diff coverage is 82.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   91.99%   91.43%   -0.56%     
==========================================
  Files          10       11       +1     
  Lines        1124     1214      +90     
==========================================
+ Hits         1034     1110      +76     
- Misses         90      104      +14     
Flag Coverage Δ
#pytests 91.43% <82.69%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/myst_amsmath.py 74.19% <74.19%> (ø)
myst_parser/__init__.py 83.33% <77.27%> (-16.67%) ⬇️
myst_parser/docutils_renderer.py 95.39% <85.71%> (-0.64%) ⬇️
myst_parser/sphinx_renderer.py 98.40% <92.85%> (+0.20%) ⬆️
myst_parser/main.py 93.75% <100.00%> (+1.25%) ⬆️
myst_parser/sphinx_parser.py 100.00% <100.00%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9dd02...835ca3c. Read the comment docs.

@chrisjsewell chrisjsewell linked an issue Aug 10, 2020 that may be closed by this pull request
@chrisjsewell chrisjsewell marked this pull request as ready for review August 11, 2020 03:58
@chrisjsewell
Copy link
Member Author

@chrisjsewell
Copy link
Member Author

chrisjsewell commented Aug 11, 2020

Plus documented the other configuration for normal math https://myst-parser--201.org.readthedocs.build/en/201/using/syntax.html#math-shortcuts

@phaustin
Copy link

looks good to me -- I do think it's worth the extra space to add one more textbox to https://myst-parser--201.org.readthedocs.build/en/201/using/syntax.html#direct-latex-math-optional below the note, showing a labeled version of (3) -- that would drive home the point that any equation can be labeled, as long as you add the $$.

@jstac
Copy link
Member

jstac commented Aug 11, 2020

Sweet :-) Thanks @chrisjsewell

I've really been missing multline.

myst_parser/__init__.py Outdated Show resolved Hide resolved
@chrisjsewell
Copy link
Member Author

prodding 👉 @choldgraf to review this 😉

@chrisjsewell chrisjsewell changed the title Add amsmath parsing Add amsmath and admonition container parsing Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants