-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👌 IMPROVE: Use __all__ to signal re-exports #120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 60 60
Lines 3242 3248 +6
=======================================
+ Hits 3115 3121 +6
Misses 127 127
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MarkdownIt
is importable from root package
@chrisjsewell To clarify why this is useful: this allows downstream projects (and markdown-it-py itself) that use the packaged type data to set from markdown_it.token import attr
from markdown_it.tree import Token If you dislike setting the from .state_core import StateCore as StateCore |
cheers, I think this is fine, one nitpick would be I think the |
This is simply what PEP8 tells us to do so following that. Hmm, I'll have a look at the docs failure in a short while. |
The issue seems to be as follows: >>> from markdown_it.rules_block.blockquote import blockquote
>>> repr(blockquote)
Out[3]: '<function blockquote at 0x7f7ebe68aaf0>'
>>> from markdown_it.rules_block import blockquote
>>> repr(blockquote)
Out[5]: '<function blockquote at 0x7f7ebe68aaf0>' The name I suggest renaming the Another way is to just ignore the Sphinx warnings. What do you think? |
Sorted it 😄
This is possibly the better solution eventually, but err I'd want to think about it some more, and so don't want to hold up this PR |
No description provided.