Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Scroll to active navigation item #609

Merged

Conversation

ksuess
Copy link
Contributor

@ksuess ksuess commented Sep 4, 2022

Fix #608

@welcome
Copy link

welcome bot commented Sep 4, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@ksuess
Copy link
Contributor Author

ksuess commented Sep 12, 2022

It would be great to have this fix merged and released before the big upgrade to current pydata-theme. @choldgraf, could you have a look?

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - I was thinking that we should wait and see if the pydata theme upgrade fixes this, but I agree that'll be a bit of a bigger change and we might as well push out this bugfix in the meantime 👍

@choldgraf choldgraf changed the title Scroll to active navigation item FIX: Scroll to active navigation item Sep 12, 2022
@choldgraf choldgraf merged commit 756bac9 into executablebooks:master Sep 12, 2022
@welcome
Copy link

welcome bot commented Sep 12, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@ksuess ksuess deleted the visability-active-navigation-item branch September 12, 2022 14:27
@ksuess
Copy link
Contributor Author

ksuess commented Sep 15, 2022

Thank you @choldgraf for reviewing and merging.
The upgrade to pydata-sphinx-theme~=0.10 will bring breaking changes. Maybe a 0.3.x release before this upgrade would be a good idea. What do you think?

@choldgraf
Copy link
Member

agreed - I created an issue to cut a patch release here:

However I don't have much time for this so I welcome others to give a shot at releasing

@AakashGfude AakashGfude mentioned this pull request Sep 27, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show active item of main navigation
2 participants