-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Scroll to active navigation item #609
FIX: Scroll to active navigation item #609
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
It would be great to have this fix merged and released before the big upgrade to current pydata-theme. @choldgraf, could you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - I was thinking that we should wait and see if the pydata theme upgrade fixes this, but I agree that'll be a bit of a bigger change and we might as well push out this bugfix in the meantime 👍
Thank you @choldgraf for reviewing and merging. |
agreed - I created an issue to cut a patch release here: However I don't have much time for this so I welcome others to give a shot at releasing |
Fix #608