ENH: sphinx >=4,<6 #644
Merged
ENH: sphinx >=4,<6 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Looks good to me - I did a quick look at the docs and they seemed to look fine to me.
I noticed that the code cells in the right margin have an extra padding added to the left, but that may not be related to this change
Can you give a quick run-through of the example docs before merging just to make sure?
@choldgraf looks like the style is getting inherited from pydata sphinx theme, which we did not overwrite: so not related to this PR. But the rest look okay to me. |
|
Coordinating with executablebooks/sphinx-thebe#57 |
This was referenced Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.