RLS 1.0.0: (repeat) Fix a link and improve test reliability #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
commented
Mar 1, 2023
choldgraf
commented
Mar 1, 2023
|
I'll wait for the linkcheck to complete on this PR, and also to confirm that codecov also runs, and will merge if so. Then we can double check that the jobs don't run on |
choldgraf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got bitten by a codecov rate limit bug (cc @AakashGfude you mentioned this in slack too) and then got bitten by a linkcheck that broke only after the release had been made. I don't think we want to block release actions on broken links, so this just runs the codecov + the linkcheck jobs on the
pull_requestevent, which means it won't trigger on thereleaseevent.