👌 IMPROVE: Add support and testing for sphinx 5 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 2 2
Lines 219 219
=======================================
Hits 203 203
Misses 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Hey @Daltz333, do you think the changes to the testing coverage here seem reasonable? |
|
Yeah this looks good! |
Daltz333
approved these changes
Jun 25, 2022
foster999
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update setup.py dependency to allow
sphinx<6.Add testing for sphinx 5, python 3.10 and pygments 2.12.0 (no functional changes since 2.10.0 for us) in Actions workflow.
Remove testing for python 3.6. The package likely continues to work with this version, but we won't continue to test it.
Remove testing for sphinx 2 and 4 (see next change).
Update regression tests outputs to account for change in sphinx HTML output text. Oddly this seems to have been applied to sphinx 3 and 5, but not 4, making it awkward for our current regression-type tests to run against 4.
Add limiting of jinja2 version due to them dropping some objects that are imported by sphinx in latest version.
Update testing to use up-to-date version of pytest, to allow testing on python 3.10.
Will resolve #162