-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests for Sphinx 7.2 #179
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
The updated regression outputs are working, but the test fixture change isn't working for Python 3.7 and 3.8 which use older versions of sphinx. Your change is in the doctree regression, but I think the change is actually in the HTML. If you want to try to address this look into using beautifulsoup to remove the title attribute from those elements in the HTML (regardless of sphinx version). This would allow us to ignore any other changes to that text in future too |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Decided that we should stop testing earlier versions of sphinx (and therefore Python), so we don't have to keep updating tests for non-functional changes to sphinx and its dependencies. |
Sphinx changed “Permalink” to “Link” in sphinx-doc/sphinx#10049.
I will try to make it backwards-compatible in the next commit.