Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change config option name to correctly select kernel #59

Closed
joergbrech opened this issue Jan 12, 2023 · 1 comment · Fixed by #60
Closed

Change config option name to correctly select kernel #59

joergbrech opened this issue Jan 12, 2023 · 1 comment · Fixed by #60
Labels
bug Something isn't working

Comments

@joergbrech
Copy link
Contributor

joergbrech commented Jan 12, 2023

Describe the bug

context

I have a jupyter-book using octave notebooks. Live-Code with thebe stopped working after updating jb to 0.13.1.

expectation.

Running live-code with thebe should work out of the box with an octave kernel, but it doesn't. Running the jupyter notebooks in mybinder.org works as expected.

bug

This seems to be caused by jupyter-book/thebe#349. If I understand correctly, thebe >= 0.6.0 requires the kernel to be set via kernelOptions.name rather than kernelOptions.kernalName. I verified this by manually adding kernelOptions.name to a locally built html file.

possible fix

After a first glance at sphinx-thebe, I suppose it could suffice to fix this line:

kernelName: "{kernel_name}",

Reproduce the bug

As a consequence, the sphinx-thebe documentation is currently broken: Running the interactive R code on https://sphinx-thebe.readthedocs.io/en/latest/configure.html does not work.

List your environment

jupyter-book version 0.13.1

@joergbrech joergbrech added the bug Something isn't working label Jan 12, 2023
@welcome
Copy link

welcome bot commented Jan 12, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

joergbrech added a commit to joergbrech/sphinx-thebe that referenced this issue Jan 12, 2023
choldgraf pushed a commit that referenced this issue Jan 17, 2023
Co-authored-by: Chris Holdgraf <[email protected]>
Fixes #59
closes #43
closes #53
Closes jupyter-book/jupyter-book#1173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant