Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Exercise: Triangle #272

Closed
wants to merge 5 commits into from
Closed

New Exercise: Triangle #272

wants to merge 5 commits into from

Conversation

ajborla
Copy link
Member

@ajborla ajborla commented Jul 31, 2023

No description provided.

larshp
larshp reviewed Jul 31, 2023
View reviewed changes
exercises/practice/triangle/.meta/zcl_triangle.clas.abap Outdated

METHOD has_negative_or_zero_sides.
result = abap_false.
IF side_a <= 0.0 OR side_b <= 0.0 OR side_c <= 0.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax error here, try

Suggested change
IF side_a <= 0.0 OR side_b <= 0.0 OR side_c <= 0.0.
IF side_a <= 0 OR side_b <= 0 OR side_c <= 0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help.

@ajborla
Copy link
Member Author

ajborla commented Jul 31, 2023

Will re-attempt a future PR after some code adjustment,

@ajborla ajborla closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshp larshp larshp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajborla @larshp