Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Exercise: Triangle #273

Closed
wants to merge 3 commits into from
Closed

New Exercise: Triangle #273

wants to merge 3 commits into from

Conversation

ajborla
Copy link
Member

@ajborla ajborla commented Aug 1, 2023

No description provided.

@larshp
Copy link
Member

larshp commented Aug 1, 2023

@ajborla please set the status to draft if its work in progress

there might be false positives from the open-abap runtime, I'll help with those once you finish the code

@ajborla ajborla marked this pull request as draft August 1, 2023 05:27
@ajborla
Copy link
Member Author

ajborla commented Aug 1, 2023

@larshp Converted PR to draft.

I believe the code is complete (it compiled, and all but one unit test passed).

I will close this PR, and resubmit when I receive a notification from you ?

Thank you very much for your help.

@ajborla ajborla closed this Aug 1, 2023
@larshp
Copy link
Member

larshp commented Aug 1, 2023

if a pull request is closed or merged I'll not look at it, I get a lot of notifications each day..

just have one pull request, push additional commits to it if needed, mark it as ready when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants