Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kindergarten-garden: fix invalid tests.toml #277

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Aug 9, 2023

This tests.toml contained invalid TOML syntax:

# for Ileana
"759070a3-1bb1-4dd4-be2c-7cce1d7679ae" = true
"for Joseph
"78578123-2755-4d4a-9c7d-e985b8dda1c6" = true
"for Kincaid, second to last student's garden
"6bb66df7-f433-41ab-aec2-3ead6e99f65b" = true
"for Larry, last student's garden
"d7edec11-6488-418a-94e6-ed509e0fa7eb" = true

which would cause configlet sync to produce an error.

The tests.toml was also using the long-outdated format. See the specification for the expected format.

Regenerate the tests.toml, without changing which tests are stated to be implemented.

The only other tests.toml file in this repo (for state-of-tic-tac-toe) uses the correct format.

Fixes: #276


Ping @ErikSchierboom

The tests.toml contained invalid TOML syntax:

    "for Joseph
    "78578123-2755-4d4a-9c7d-e985b8dda1c6" = true

    "for Kincaid, second to last student's garden
    "6bb66df7-f433-41ab-aec2-3ead6e99f65b" = true

    "for Larry, last student's garden
    "d7edec11-6488-418a-94e6-ed509e0fa7eb" = true

and was using the long-outdated format [1]. See the specification for
the expected format [2].

Regenerate the tests.toml, without changing which tests are stated to be
implemented.

The only other tests.toml file in this repo (for state-of-tic-tac-toe)
uses the correct format.

Fixes: exercism#276

[1] exercism/configlet#198
[2] https://exercism.org/docs/building/configlet/sync#h-tests
@larshp larshp merged commit 0ffc343 into exercism:main Aug 9, 2023
4 checks passed
@ee7 ee7 deleted the kindergarten-garden-fix-invalid-toml branch August 9, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kindergarten-garden: invalid tests.toml
2 participants