sync: improve error handling #699
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace: - `showError` with `errorAndHelp` - (`stderr.writeLine msg` then `quit 1`) with `error` Refs: 123 Refs: 325
Replace: - `showError` with `errorAndHelp` - (`stderr.writeLine msg` then `quit 1`) with `error` Refs: 123 Refs: 325
ee7
force-pushed
the
sync-improve-error-handling
branch
from
fbf8109
to
658fef6
Compare
|
@ee7 Is this something you'd still like to do? It looks like a nice improvement |
|
It's probably an improvement overall, but please take over if you want it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace:
showErrorwitherrorAndHelpstderr.writeLine msgthenquit 1) witherrorRefs: #123
Refs: #325
Working towards the approach that I use elsewhere, including:
configlet/bin/bump_version.nim
Lines 17 to 19 in b6fff14