Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.18 #72

Merged
merged 7 commits into from
Jul 9, 2022
Merged

Update to Go 1.18 #72

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3df791c
chore: bumped go to version 1.18
Apr 12, 2022
ba7e624
chore: PR comments for global gitignore
pedreviljoen Apr 13, 2022
e59da9e
Merge branch 'exercism:main' into main
pedreviljoen May 12, 2022
1c74e96
added: updated golang lint action version
pedreviljoen May 12, 2022
9d771dd
added: bump action version for setup-go & checkout
pedreviljoen May 26, 2022
bf21505
fix: code coverage failing unit tests
pedreviljoen May 30, 2022
c93c267
fix: code coverage failing unit tests
pedreviljoen May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,20 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Install Go
uses: actions/setup-go@v2
uses: actions/setup-go@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our GHA recommendations guide has a section on pinning actions to SHAs, for security purposes. Admittedly, the actions/ actions are less likely to be affected, but this workflow also uses some workflows developed by third-parties, for which I'd definitely recommend pinning them. It's totally fine to do this in a follow-up PR.

with:
go-version: 1.17.x
go-version: 1.18.x
- name: Checkout code
uses: actions/checkout@v2
- name: Run linters
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v3
with:
version: v1.43
version: v1.46

test:
strategy:
matrix:
go-version: [1.17.x]
go-version: [1.18.x]
# platform: [ubuntu-latest, macos-latest, windows-latest]
platform: [ubuntu-latest]
runs-on: ${{ matrix.platform }}
Expand All @@ -43,7 +43,7 @@ jobs:
if: success()
uses: actions/setup-go@v2
with:
go-version: 1.17.x
go-version: 1.18.x
- name: Checkout code
uses: actions/checkout@v2
- name: Calc coverage
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.17-alpine3.14
FROM golang:1.18-alpine3.15

# add addtional packages needed for the race detector to work
RUN apk add --update build-base make
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module github.com/exercism/go-test-runner

go 1.17
go 1.18
2 changes: 1 addition & 1 deletion testrunner/testdata/concept/conditionals/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module conditionals

go 1.17
go 1.18
2 changes: 1 addition & 1 deletion testrunner/testdata/practice/broken/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module gigasecond

go 1.17
go 1.18
2 changes: 1 addition & 1 deletion testrunner/testdata/practice/broken_import/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module gigasecond

go 1.17
go 1.18
2 changes: 1 addition & 1 deletion testrunner/testdata/practice/failing/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module gigasecond

go 1.17
go 1.18
2 changes: 1 addition & 1 deletion testrunner/testdata/practice/gigasecond/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module gigasecond

go 1.17
go 1.18
2 changes: 1 addition & 1 deletion testrunner/testdata/practice/missing_func/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module gigasecond

go 1.17
go 1.18
2 changes: 1 addition & 1 deletion testrunner/testdata/practice/passing/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module gigasecond

go 1.17
go 1.18
2 changes: 1 addition & 1 deletion testrunner/testdata/practice/pkg_level_error/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module pov

go 1.17
go 1.18

2 changes: 1 addition & 1 deletion testrunner/testdata/practice/runtime_error/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module gigasecond

go 1.17
go 1.18