-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Go 1.18 #72
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3df791c
chore: bumped go to version 1.18
ba7e624
chore: PR comments for global gitignore
pedreviljoen e59da9e
Merge branch 'exercism:main' into main
pedreviljoen 1c74e96
added: updated golang lint action version
pedreviljoen 9d771dd
added: bump action version for setup-go & checkout
pedreviljoen bf21505
fix: code coverage failing unit tests
pedreviljoen c93c267
fix: code coverage failing unit tests
pedreviljoen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,31 +8,31 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Install Go | ||
| uses: actions/setup-go@v2 | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.17.x | ||
| go-version: 1.18.x | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v3 | ||
| - name: Run linters | ||
| uses: golangci/golangci-lint-action@v2 | ||
| uses: golangci/golangci-lint-action@v3 | ||
| with: | ||
| version: v1.43 | ||
| version: v1.46 | ||
|
|
||
| test: | ||
| strategy: | ||
| matrix: | ||
| go-version: [1.17.x] | ||
| go-version: [1.18.x] | ||
| # platform: [ubuntu-latest, macos-latest, windows-latest] | ||
| platform: [ubuntu-latest] | ||
| runs-on: ${{ matrix.platform }} | ||
| steps: | ||
| - name: Install Go | ||
| if: success() | ||
| uses: actions/setup-go@v2 | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: ${{ matrix.go-version }} | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v3 | ||
| - name: Run tests | ||
| run: go test ./... -v -covermode=count | ||
|
|
||
|
|
@@ -41,18 +41,18 @@ jobs: | |
| steps: | ||
| - name: Install Go | ||
| if: success() | ||
| uses: actions/setup-go@v2 | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.17.x | ||
| go-version: 1.18.x | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v3 | ||
| - name: Calc coverage | ||
| run: | | ||
| go test ./... -v -covermode=count -coverprofile=coverage.out | ||
| - name: Convert coverage.out to coverage.lcov | ||
| uses: jandelgado/[email protected].6 | ||
| uses: jandelgado/[email protected].9 | ||
| - name: Coveralls | ||
| uses: coverallsapp/[email protected].2 | ||
| uses: coverallsapp/[email protected].3 | ||
andrerfcsantos marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| with: | ||
| github-token: ${{ secrets.github_token }} | ||
| path-to-lcov: coverage.lcov | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module github.com/exercism/go-test-runner | ||
|
|
||
| go 1.17 | ||
| go 1.18 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module conditionals | ||
|
|
||
| go 1.17 | ||
| go 1.18 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module gigasecond | ||
|
|
||
| go 1.17 | ||
| go 1.18 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module gigasecond | ||
|
|
||
| go 1.17 | ||
| go 1.18 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module gigasecond | ||
|
|
||
| go 1.17 | ||
| go 1.18 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module gigasecond | ||
|
|
||
| go 1.17 | ||
| go 1.18 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module gigasecond | ||
|
|
||
| go 1.17 | ||
| go 1.18 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module gigasecond | ||
|
|
||
| go 1.17 | ||
| go 1.18 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| module pov | ||
|
|
||
| go 1.17 | ||
| go 1.18 | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module gigasecond | ||
|
|
||
| go 1.17 | ||
| go 1.18 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our GHA recommendations guide has a section on pinning actions to SHAs, for security purposes. Admittedly, the
actions/actions are less likely to be affected, but this workflow also uses some workflows developed by third-parties, for which I'd definitely recommend pinning them. It's totally fine to do this in a follow-up PR.