-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concept stringers with exercise #2208
Conversation
Dear norbs57Thank you for contributing to the Go track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
Fixes exercism#2184 New concept stringers New concept exercise Meteorology
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First attempt at reviewing 👍 😃 Thanks for creating this! I'll read the test cases a bit later and have currently 1 question and 1 nitpick.
Co-authored-by: Nahua <[email protected]>
Thanks Nahua! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are 👍 I just have 1 more comment but maybe @junedev or @andrerfcsantos are more suitable to judge whether this comment from me is a good idea or not. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for making this exercise. What you have here is an excellent foundation for the exercise already, so well done!
I left some suggestions in the about.md
file, but of course please make those changes in the other places were they are needed too.
And feel free to disagree with the suggestions :)
Update concepts/stringers/about.md Co-Authored-By: André Santos <[email protected]>
Co-authored-by: André Santos <[email protected]>
Co-authored-by: André Santos <[email protected]>
Co-authored-by: André Santos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more changes
I would like to pass on this PR - it would be great if someone else could finish it. |
@norbs57 I can finish it up for you - no worries :) |
Fixes #2184
New concept stringers
New concept exercise Meteorology