Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Maven #18

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Switch to Maven #18

merged 5 commits into from
Nov 16, 2021

Conversation

andreaTP
Copy link
Contributor

@ErikSchierboom for now I dropped the "colorization" of the output, feel free to suggest an appropriate command if you prefer to have it back 🙂 , also doublecheck my results please 🙏

side note, we can test something like:

export JAVA_TOOL_OPTIONS="-Xss128m -Xms256m -Xmx2G -XX:+UseG1GC"

even in the java-runner.

@andreaTP andreaTP requested a review from a team as a code owner November 13, 2021 12:15
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! On my Macbook, the run time goes from 19 seconds to 9 seconds!

I added 1019932 for the colorization.

@ErikSchierboom
Copy link
Member

@andreaTP Same question as for the Java change: is this safe to merge?

@andreaTP
Copy link
Contributor Author

On my Macbook, the run time goes from 19 seconds to 9 seconds!

Wow, @ErikSchierboom we do have seriously different machines! On mine, I had a much smaller improvement here (3-4 seconds).

is this safe to merge?

The answer is: "It should be" 🙂 , in the repo: https://github.com/exercism/groovy 55 out of 55 build.gradle files contain:

dependencies {
    testImplementation "org.spockframework:spock-core:2.0-M2-groovy-3.0"
    implementation "org.codehaus.groovy:groovy-all:3.0.2"
}

with maven we are bumping a little the versions (within the semver boundaries):

groovy -> 3.0.8
spock -> 2.0-groovy-3.0

Probably it would be good to do(at least) the version bump in the exercises repo too, but all of this is supposed to be safe.

@ErikSchierboom
Copy link
Member

Probably it would be good to do(at least) the version bump in the exercises repo too, but all of this is supposed to be safe.

So even without the version bump in the exercises, they'll run successfully on the test runner?

@andreaTP
Copy link
Contributor Author

So even without the version bump in the exercises, they'll run successfully on the test runner?

everything I tested is running as expected, so, at best of my knowledge, yes 👍

@ErikSchierboom ErikSchierboom merged commit 2c52ac9 into exercism:main Nov 16, 2021
@ErikSchierboom
Copy link
Member

Merging! Thanks @andreaTP

@ErikSchierboom
Copy link
Member

@andreaTP I've just tested, and I had a 10 seconds test run for hello-world, so that's great! Can this (using Maven) also be applied to Kotlin?

@andreaTP
Copy link
Contributor Author

@ErikSchierboom very likely, I will try to have a look, great that is working! Do you have stats of overall timeouts (even for java)?

@ErikSchierboom
Copy link
Member

@andreaTP I don't think we're keeping track of the execution time yet. I think it is somewhere on my todo list :)

@iHiD
Copy link
Member

iHiD commented Nov 16, 2021

@andreaTP You're a lifesaver!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants