-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Maven #18
Switch to Maven #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! On my Macbook, the run time goes from 19 seconds to 9 seconds!
I added 1019932 for the colorization.
@andreaTP Same question as for the Java change: is this safe to merge? |
Wow, @ErikSchierboom we do have seriously different machines! On mine, I had a much smaller improvement here (3-4 seconds).
The answer is: "It should be" 🙂 , in the repo: https://github.com/exercism/groovy 55 out of 55
with maven we are bumping a little the versions (within the semver boundaries):
Probably it would be good to do(at least) the version bump in the exercises repo too, but all of this is supposed to be safe. |
So even without the version bump in the exercises, they'll run successfully on the test runner? |
everything I tested is running as expected, so, at best of my knowledge, yes 👍 |
Merging! Thanks @andreaTP |
@andreaTP I've just tested, and I had a 10 seconds test run for hello-world, so that's great! Can this (using Maven) also be applied to Kotlin? |
@ErikSchierboom very likely, I will try to have a look, great that is working! Do you have stats of overall timeouts (even for java)? |
@andreaTP I don't think we're keeping track of the execution time yet. I think it is somewhere on my todo list :) |
@andreaTP You're a lifesaver! |
@ErikSchierboom for now I dropped the "colorization" of the output, feel free to suggest an appropriate command if you prefer to have it back 🙂 , also doublecheck my results please 🙏
side note, we can test something like:
even in the
java-runner
.