Initial files #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alirezaghey feel free to push to this branch and we'll just merge it in one go? |
|
Opened a bunch of issues yesterday, thinking I'll do small feature PRs just for the sake of completeness and learning, but your suggestion is more practical. |
|
You can PR into this branch! So you can do as you suggest, and then we merge it into this branch instead. |
|
You are correct, that's what I'm going to do. |
|
Thank you for your work! I've gone ahead and made some changes. Merging this so I can test this out with @ccare |
|
Exciting! |
ErikSchierboom
added
x:size/large
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.