Merge pull request #329 from bencoman/custom-QA-rule

custom-QA-rule
exercism · May 16, 2019 · 4ddd170 · 4ddd170
2 parents 6d18367 + 4c16e20
commit 4ddd170
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 0 deletions.
diff --git a/dev/src/ExercismTools/ExercismHintRule.class.st b/dev/src/ExercismTools/ExercismHintRule.class.st
@@ -0,0 +1,16 @@
+Class {
+	#name : #ExercismHintRule,
+	#superclass : #ReAbstractRule,
+	#category : #ExercismTools
+}
+
+{ #category : #accessing }
+ExercismHintRule >> group [
+	^'Exercism Hint'
+]
+
+{ #category : #accessing }
+ExercismHintRule >> severity [
+	^ #warning
+
+]
diff --git a/dev/src/ExercismTools/ExercismHintTwoFerReuseRule.class.st b/dev/src/ExercismTools/ExercismHintTwoFerReuseRule.class.st
@@ -0,0 +1,30 @@
+"
+The TwoFer exercise introduces you to calling between methods.
+For practice, your '#who'  method should reuse your  '#who:'  method. 
+"
+Class {
+	#name : #ExercismHintTwoFerReuseRule,
+	#superclass : #ExercismHintRule,
+	#category : #ExercismTools
+}
+
+{ #category : #'testing-interest' }
+ExercismHintTwoFerReuseRule class >> checksMethod [
+	^true
+]
+
+{ #category : #accessing }
+ExercismHintTwoFerReuseRule >> basicCheck: compiledMethod [
+	compiledMethod methodClass name = #TwoFer ifTrue: [ 
+		|literals|
+		literals := compiledMethod sourceCode parseLiterals.
+		literals first = #who ifTrue: [ ^ (literals includes: #who:) not ].
+		].
+	^false
+
+]
+
+{ #category : #accessing }
+ExercismHintTwoFerReuseRule >> name [
+	^ 'Exercism: Method #who should reuse method #who: '
+]