Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pig-latin: update tests to version 1.1.0 #1034

Merged
merged 8 commits into from
Oct 30, 2017
Merged

pig-latin: update tests to version 1.1.0 #1034

merged 8 commits into from
Oct 30, 2017

Conversation

kishan3
Copy link

@kishan3 kishan3 commented Oct 25, 2017

Resolves #1019

@kishan3 kishan3 changed the title Updates tests pig-latin: update tests to version 1.1.0 Oct 26, 2017
@cmccandless cmccandless self-assigned this Oct 26, 2017
@cmccandless
Copy link
Contributor

@kishan3 Thanks for your pull request! In order to merge your changes, the example solution (example.py) must also be updated to pass the new tests. Please make the appropriate changes.

@kishan3
Copy link
Author

kishan3 commented Oct 30, 2017

@cmccandless not sure how can I do that. Can you help for it?

@N-Parsons
Copy link
Contributor

Thanks for your work @kishan3! It just needed a slight tweak to the regex for consonant sounds.

My solution was to treat y as a vowel in the simplest case ([^aeiouy]) and then add a test for y followed by a vowel (y(?=[aeiou])). The construct (?=[aeiou]) does a lookahead for [aeiou] but is non-capturing, meaning that the vowels go into the second group. If you want to learn more about regex, I would suggest looking in the Python docs.

@N-Parsons N-Parsons merged commit fda6e47 into exercism:master Oct 30, 2017
@kishan3
Copy link
Author

kishan3 commented Oct 30, 2017

Thank you, sir @N-Parsons for the explanation. Learned many things from you.

smalley pushed a commit to smalley/python that referenced this pull request Nov 12, 2017
* pig-latin: Updates tests

* pig-latin: Fix example to work with new tests
smalley pushed a commit to smalley/python that referenced this pull request Nov 12, 2017
* pig-latin: Updates tests

* pig-latin: Fix example to work with new tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants