Add spiral-matrix #1170
Add spiral-matrix #1170
Conversation
config.json
Outdated
| "algorithms", | ||
| "control-flow", | ||
| "lists", | ||
| "logic" |
There was a problem hiding this comment.
I don't think that logic really applies to this exercise. A better example would be the zebra-puzzle exercise.
There was a problem hiding this comment.
Good point, @cmccandless. I decided to delete "logic" from the list of topics.
|
|
||
| from spiral_matrix import spiral | ||
|
|
||
|
|
There was a problem hiding this comment.
Please add a comment referencing the current version of the canonical data. For the format of this comment, please see #784.
There was a problem hiding this comment.
Done. Thanks for the hint.
config.json
Outdated
| "algorithms", | ||
| "control-flow", | ||
| "lists", | ||
| "logic" |
There was a problem hiding this comment.
Good point, @cmccandless. I decided to delete "logic" from the list of topics.
|
|
||
| from spiral_matrix import spiral | ||
|
|
||
|
|
There was a problem hiding this comment.
Done. Thanks for the hint.
|
@chgraef Please add a reference to #752 to the PR description (see magic words). |
|
|
||
| from spiral_matrix import spiral | ||
|
|
||
| # Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0 |
There was a problem hiding this comment.
Can you move this line down by one to be more consistent with the other test files?
There was a problem hiding this comment.
Thanks, @N-Parsons ,will do.
There was a problem hiding this comment.
I believe for full consistency, you the spacing should be 2 blank lines above, one below (see below):
from spiral_matrix...
# Tests adapted from...
class...
|
@chgraef Merged; thanks for working on this! |
[Docs] Add reference to required reading in implementing guide
[Docs] Add reference to required reading in implementing guide
[Docs] Add reference to required reading in implementing guide
[Docs] Add reference to required reading in implementing guide
Implementing exercise spiral-matrix. Closes #752