Clean up on the List and List-Method Isles #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exercise introductons.
IsaacG
reviewed
Apr 22, 2021
exercises/concept/chaitanas-colossal-coaster/.docs/instructions.md
Outdated
Show resolved
Hide resolved
exercises/concept/chaitanas-colossal-coaster/.docs/instructions.md
Outdated
Show resolved
Hide resolved
| 3. ticket_type is an `int` with 1 for the express queue and 0 for the normal queue. | ||
| 4. person_name is the name of the person to be added to the respective queue. | ||
|
|
||
| 1. ticket_type is an `int` with 1 == express_queue and 0 == normal_queue. |
There was a problem hiding this comment.
This looks too much like a Yoda Conditional and like you're comparing an int to a list.
There was a problem hiding this comment.
Yup. Agree. Needs ... love. Do you think we should chuck and re-write this exercise? Its fine if you do. I was resisting, since there is a lot here..but the queue thing is starting to not work for me. Thoughts?
There was a problem hiding this comment.
The multi-queue is only used for this one function so it can probably be dropped without impacting the other functions. If you want the add() to do more than append() you can have it only add if the person is not in the queue already.
exercises/concept/chaitanas-colossal-coaster/.docs/introduction.md
Outdated
Show resolved
Hide resolved
exercises/concept/chaitanas-colossal-coaster/.docs/introduction.md
Outdated
Show resolved
Hide resolved
exercises/concept/chaitanas-colossal-coaster/.docs/introduction.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
BethanyG
commented
Apr 22, 2021
Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
…s.md Co-authored-by: Isaac Good <[email protected]>
…s.md Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
BethanyG
commented
Apr 22, 2021
exercises/concept/chaitanas-colossal-coaster/.docs/introduction.md
Outdated
Show resolved
Hide resolved
BethanyG
commented
Apr 22, 2021
exercises/concept/chaitanas-colossal-coaster/.docs/introduction.md
Outdated
Show resolved
Hide resolved
BethanyG
commented
Apr 22, 2021
exercises/concept/chaitanas-colossal-coaster/.docs/introduction.md
Outdated
Show resolved
Hide resolved
BethanyG
commented
Apr 22, 2021
BethanyG
commented
Apr 22, 2021
BethanyG
commented
Apr 22, 2021
BethanyG
commented
Apr 22, 2021
BethanyG
commented
Apr 22, 2021
exercises/concept/chaitanas-colossal-coaster/.docs/introduction.md
Outdated
Show resolved
Hide resolved
BethanyG
commented
Apr 22, 2021
exercises/concept/chaitanas-colossal-coaster/.docs/introduction.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Isaac Good <[email protected]>
cmccandless
approved these changes
Apr 27, 2021
BethanyG
added
improve exercise 💖
reputation/contributed_code/major
x:size/large
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs nits and spelling patrol, but I am hoping that the concept related writing is now in good shape.
Re-worked the following:
about.mdforlistsandlist-methodsindtroduction.mdforlistsandlist-methodsintroduction.mdforchaitanas-colossal-coaster(coveringlist-methods)indroduction.mdforelyses-enchantments(coveringlists)