Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chiatana's Colossal Coaster]: Update Tests to Verify Queue has been Updated #3799

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

lukemcguire
Copy link
Contributor

Description

In Chaitana's Colossal Coaster, the test for taskno=6 only checked that the correct name was returned, it did not verify that the queue was updated to remove the last person from the queue. This change adds a second test to taskno=6 to validate the queue.

Checklist before requesting review

  • Discussed the issue with one of the maintainers (@BethanyG )
  • Verified the test file runs against the exemplar.py file with no issues

This comment was marked as resolved.

@github-actions github-actions bot closed this Oct 23, 2024
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@BethanyG
Copy link
Member

🎉

@BethanyG BethanyG reopened this Oct 23, 2024
@BethanyG BethanyG changed the title test: Update Chaitana's tests to verify queue has been updated [Chiatana's Colossal Coaster]: Update Tests to Verify Queue has been Updated Oct 23, 2024
@BethanyG
Copy link
Member

Wow. All that convo and I didn't merge. APOLOGIES. Merging now. Thank you for submitting this!! 🎉

@BethanyG BethanyG merged commit 5f70c9d into exercism:main Oct 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants