Run concept exercises in CI #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For us to be able to run the exercise tests against the exemplar implementations, their file names should match the file names in the solution to get the imports to work. Therefore, instead of having a `.meta/Exemplar.swift` file in every concept exercise, the exemplar implementations have been moved to `.meta/ExemplarSources` and renamed to match the solution file.
Closed
ErikSchierboom
approved these changes
Sep 30, 2021
|
@sanderploegsma We have a passing CI system again! |
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #469 by adding the concept exercises to the root
Package.swift.To get this working one change to the exercises was required: the exemplar implementations were all in
.meta/Exemplar.swiftfiles, which caused the exercise's tests to fail on the imports. I therefore moved all exemplar implementations to.meta/Sources/[ExerciseName]/[ExerciseName]Exemplar.swiftand updated theconfig.jsonfiles accordingly.Note that I removed the creation of
LinuxMain.swiftin the SPM manifest since the CI job no longer runs on Linux, so this is not necessary.