Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline_window to correctly handle stride dimension #276

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

yamaguchi1024
Copy link
Member

@yamaguchi1024 yamaguchi1024 commented Nov 4, 2022

This was the source problem of gemmini stride issue in api-audit-and-fix we saw earilier

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #276 (d0c5b50) into master (f412212) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   87.86%   87.82%   -0.04%     
==========================================
  Files          72       72              
  Lines       15529    15538       +9     
==========================================
+ Hits        13644    13647       +3     
- Misses       1885     1891       +6     
Impacted Files Coverage Δ
src/exo/LoopIR_scheduling.py 90.24% <100.00%> (+0.03%) ⬆️
src/exo/platforms/gemmini.py 93.37% <100.00%> (ø)
tests/test_x86.py 98.36% <0.00%> (-1.64%) ⬇️
src/exo/LoopIR_compiler.py 94.31% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/exo/LoopIR_scheduling.py Show resolved Hide resolved
src/exo/platforms/gemmini.py Show resolved Hide resolved
@alexreinking
Copy link
Contributor

Also, yay, I fixed the code-coverage bot!

Copy link
Contributor

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@yamaguchi1024 yamaguchi1024 merged commit 233c060 into master Nov 4, 2022
@yamaguchi1024 yamaguchi1024 deleted the fix_inline branch November 4, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants