Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding systems to map does not update the map #103

Closed
atkinsj opened this issue Feb 29, 2016 · 2 comments
Closed

Adding systems to map does not update the map #103

atkinsj opened this issue Feb 29, 2016 · 2 comments
Assignees
Milestone

Comments

@atkinsj
Copy link

atkinsj commented Feb 29, 2016

There's a pretty critical bug at the moment where if you create a new map then add a system to it, the dialog does not close and the map does not update. Attempting to add the same system again results in an Error 500 and if you check the logs you will see:

[Mon Feb 29 20:51:23.196348 2016] [:error] [pid 48631] [client 127.0.0.1:65325] PDOStatement: Duplicate entry '7-30002036' for key 'system___mapId__systemId', referer: http://pathfinder.dev/map

The system is in the database and has been added but the map is not updating, this does not seem to be due to cache control. I've reproduced this on my local developer box, my hosted copy and on https://www.pathfinder-w.space.

I'm unsure if this is related but it appears once the bug is triggered, selecting the 'Add button' to add a new map results in the attached. This is on Chrome 48 on OSX 10.11.

The JavaScript console shows: Uncaught TypeError: Cannot read property 'updated' of undefined map.js:601

brokenadd

@atkinsj
Copy link
Author

atkinsj commented Feb 29, 2016

Looks like a rename snafu in js/app/map/map.js -- 'data.updated.updated' instead of 'data.updated'.

@exodus4d
Copy link
Owner

Thanks for reporting!

This should be fixed with #114 (users are no longer able to store same system multiple times)
The error is thrown by the DB, (combination of mapId and systemId is a uniquekey) - which is OK

I checked the code again, and there is still something to improve ;)

@exodus4d exodus4d added this to the v 1.0.0RC3 milestone Apr 11, 2016
@exodus4d exodus4d self-assigned this Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants