Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --spans-key option for CLI spancat evaluation #12981

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

evornov
Copy link
Contributor

@evornov evornov commented Sep 13, 2023

Description

The internal evaluate method called by the evaluate/benchmark accuracy CLI commands accepts a spans_key value, but the CLI command itself does not. This PR adds a --spans-key option so that the CLI can be used to evaluate spancat models with span key values other than the default sc.

I also updated the CLI documentation, but I didn't add a "new" tag because I'm not sure what the version would be there.

Types of change

Minor CLI enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added feat / cli Feature: Command-line interface feat / spancat Feature: Span Categorizer enhancement Feature requests and improvements labels Sep 14, 2023
@adrianeboyd
Copy link
Contributor

Thanks for the useful PR, especially with docs! I'm not sure why this wasn't added much sooner.

Do you mind if I push to your branch directly to rephrase the docs a bit? No problem if you'd rather not, I could do it in a follow-up PR instead.

@evornov
Copy link
Contributor Author

evornov commented Sep 14, 2023

Yes, you can go ahead and push to my branch. Thanks!

@adrianeboyd adrianeboyd merged commit 4e3360a into explosion:master Sep 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / cli Feature: Command-line interface feat / spancat Feature: Span Categorizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants