Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Any comparisons for Token and Span #13058

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Support Any comparisons for Token and Span #13058

merged 2 commits into from
Oct 12, 2023

Conversation

adrianeboyd
Copy link
Contributor

Description

Support Any comparisons for Token and Span.

  • Update Token type stubs to reflect python methods.

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects labels Oct 11, 2023
@adrianeboyd adrianeboyd linked an issue Oct 11, 2023 that may be closed by this pull request
Equals TypeError #13057
Closed
svlandeg
svlandeg approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@svlandeg svlandeg merged commit ea1befa into explosion:master Oct 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equals TypeError
2 participants
@adrianeboyd @svlandeg