Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💫Fix SP tag, tweak Vectors.__init__, fix Morphology #1442

Merged
merged 8 commits into from
Oct 24, 2017
Merged

💫Fix SP tag, tweak Vectors.__init__, fix Morphology #1442

merged 8 commits into from
Oct 24, 2017

Commits on Oct 20, 2017

  1. Fix initialization of vectors, to address serialization problem

    @honnibal
    honnibal committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    92ac931 View commit details
    Browse the repository at this point in the history

  2. Remove cpdef enum, to avoid too much code generation

    @honnibal
    honnibal committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    6218af0 View commit details
    Browse the repository at this point in the history

  3. Remove cpdef enum, to avoid too much code generation

    @honnibal
    honnibal committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    506cf2e View commit details
    Browse the repository at this point in the history

  4. Rename 'SP' special tag to '_SP' 

    Renaming the tag with an underscore lets us add it to the tag map
without worrying that we'll change the sequence of tags, which throws
off the tag-to-ID mapping. For instance, if we inserted a 'SP' tag,
the "VERB" tag is pushed to a different class ID, and the model is all
messed up.
    @honnibal
    honnibal committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    49895fb View commit details
    Browse the repository at this point in the history

  5. Make 'data_or_width' two keyword args in Vectors.__init__ 

    Previously the data and width options were one argument in Vectors,
which meant you couldn't say vectors = Vectors(strings, width=300).
It's better to have two keywords.
    @honnibal
    honnibal committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    ebecadd View commit details
    Browse the repository at this point in the history

  6. Make change to Vectors.__init__

    @honnibal
    honnibal committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    cfae54c View commit details
    Browse the repository at this point in the history

  7. Remove print statement

    @honnibal
    honnibal committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    33229b1 View commit details
    Browse the repository at this point in the history

  8. Create vectors correctly

    @honnibal
    honnibal committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    9010a1a View commit details
    Browse the repository at this point in the history