-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to add ability to clean up StringStore in pipe #1552
Conversation
Hi @ligser, thanks for your pull request! 👍 It looks like you haven't filled in the spaCy Contributor Agreement (SCA) yet. The agrement ensures that we can use your contribution across the project. Once you've filled in the template, put it in the |
This looks very promising. Thank you for taking the time to do this efficiently. |
Very good, thanks! |
@honnibal I realize that here I broke swapping of recent and old refs. I afraid that change can cause the error: if |
I understand. My fix not cleans up strings — just keys. 😐 |
I made a new pull request to fix it. Sorry. |
Description
I try to fix #1506 by allowing StringStore to clean up old strings when using it to iterate through many documents in a pipe. I try to do it with little effort on memory or speed, but I might not see all effect of my changes.
Because that method is written as the feature only for
pipe
method of the Language class — the method marked as internal by the underscore.Types of change
It's bug fix.
Checklist