Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary itertools call #5157

Merged
merged 1 commit into from
Mar 16, 2020
Merged

remove unnecessary itertools call #5157

merged 1 commit into from
Mar 16, 2020

Conversation

svlandeg
Copy link
Member

I stumbled upon these unnecessary lines and found that this already got fixed in master (#5101), but we need it on develop as well. And for some reason cherry-picking didn't work.

Types of change

bug fix

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added bug Bugs and behaviour differing from documentation feat / pipeline Feature: Processing pipeline and components perf / memory Performance: memory use labels Mar 16, 2020
@ines ines merged commit 5580320 into explosion:develop Mar 16, 2020
@ines ines deleted the bugfix/language branch March 16, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / pipeline Feature: Processing pipeline and components perf / memory Performance: memory use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svlandeg @ines