Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is_base_form from French lemmatizer #5733

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Remove is_base_form from French lemmatizer #5733

merged 1 commit into from
Jul 9, 2020

Conversation

adrianeboyd
Copy link
Contributor

Description

Remove English-specific is_base_form from French lemmatizer.

Fixes #5728.

Types of change

Bug fix.

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Remove is_base_form from French lemmatizer
db63fd5 
Remove English-specific is_base_form from French lemmatizer.
@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation lang / fr French language data and models labels Jul 9, 2020
@honnibal honnibal merged commit 923affd into explosion:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation lang / fr French language data and models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NoneType uncallable on spacy.load('fr') (if self.is_base_form(univ_pos, morphology))
2 participants
@adrianeboyd @honnibal