Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sunset package as outlined in RFC 0759 #933

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jun 5, 2024

RFC proposal Current CLI output
image image

Note, the URL used is https://reactnative.dev/docs/environment-setup and not the URL from the RFC https://reactnative.dev/docs/getting-started. This is mostly because the getting-started doc is more related to "how to use the docs" instead of the environment setup doc, which is related to actually setting up a project.

Additional things

  • Updated scripts to use expo-module-scripts, except for ncc
  • Updated major version number, as it's breaking
  • Updated tests with message checks

This change is planned to go live when React Native 0.75 is ready, see RFC 0759 for more info.

Copy link

github-actions bot commented Jun 5, 2024

Size Change: -204 kB (-95.73%) 🏆

Total Size: 9.09 kB

Filename Size Change
build/index.js 9.09 kB -204 kB (-95.73%) 🏆

compressed-size-action

@byCedric byCedric requested a review from EvanBacon June 5, 2024 17:09
@byCedric byCedric force-pushed the deprecation branch 12 times, most recently from 7ead516 to d4d6cf9 Compare June 5, 2024 17:27
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, the URL used is https://reactnative.dev/docs/environment-setup and not the URL from the RFC https://reactnative.dev/docs/getting-started. This is mostly because the getting-started doc is more related to "how to use the docs" instead of the environment setup doc, which is related to actually setting up a project.

this is the right choice imo!

Copy link

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@byCedric byCedric merged commit 3a7b11e into main Jul 2, 2024
2 checks passed
@byCedric byCedric deleted the deprecation branch July 2, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants