[cli][xdl] bump inquirer

[quinlanj]

why

bump inquirer to fix some problems we were experiencing
fixes #2224

breaking changes

afaik the bump from 5.2.0 to 7.3.0 doesn't affect us. The breaking changes include:

• Update to Rx.js v6
• Dropping support for Node 6

For more details, see these inquirer release notes

manual tests

• ran a couple of expo cli commands that have prompts in them to do a quick sanity check

[fson]

My only concern is that the version bump is going to cause a major regression in our installation size, because react-dev-tools still depends on an older version of inquirer, so we end up depending on both.

yarn why inquirer shows both this:

=> Found "[email protected]"
info Has been hoisted to "inquirer"
info Reasons this module exists
   - "workspace-aggregator-c7915d7a-6a15-4094-ae38-e5832b4eb142" depends on it
   - Hoisted from "_project_#eslint#inquirer"
   - Hoisted from "_project_#@expo#webpack-config#react-dev-utils#inquirer"
info Disk size without dependencies: "448KB"
info Disk size with unique dependencies: "22.8MB"
info Disk size with transitive dependencies: "24.05MB"

and this:

=> Found "expo-cli#[email protected]"
info This module exists because "_project_#expo-cli" depends on it.
info Disk size without dependencies: "216KB"
info Disk size with unique dependencies: "22.57MB"
info Disk size with transitive dependencies: "23.82MB"

(the other versions are from devDependencies so they shouldn't have an effect).

As you can see, inquirer is ~24MB unpacked. Most of that, ~17MB of that comes from rxjs, and since inquirer bumped the rxjs version, we would depend on two versions of rxjs after this change.

Solutions:

• as a long term solution to these problems, we're in the process of moving away from inquirer, see Migrate from inquirer to prompts #1983. Maybe let's see if we can move the problematic lists to use prompts already? prompts.ts is a replacement for prompts.ts that @byCedric added that uses prompts instead of inquirer. (However, I'm not sure how well prompts handles these long lists, but it's a lot smaller library.)
• alternatively, as an interim solution, we could send a PR to bump inquirer to 7.3.0 in react-dev-utils and bump our react-dev-utils version (this is on our TODO list anyway, update react-dev-utils #2016, since it also has a fix for expo start hangs when opening browser, ignores all input and options #1004) so that the same version is used in both.

[EvanBacon]

Opened a PR to replace inquirer with prompts in create-react-app facebook/create-react-app#10083