Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TSConfig, clean up ESLint rules #123

Merged
merged 1 commit into from
Nov 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,9 @@ module.exports = {
'plugin:@typescript-eslint/recommended',
],
rules: {
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/explicit-member-accessibility': [
'error', { 'accessibility': 'no-public' },
],
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/indent': ['error', 'tab'],
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-use-before-define': 'off',
'@typescript-eslint/no-explicit-any': 'off',
},
};
4 changes: 2 additions & 2 deletions src/cache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export async function fromRemoteCache(config: CacheConfig): Promise<string | und
if (hit) {
return target;
}
} catch (error: any) {
} catch (error) {
if (!handleRemoteCacheError(error)) {
throw error;
}
Expand All @@ -59,7 +59,7 @@ export async function toRemoteCache(source: string, config: CacheConfig): Promis

try {
await saveCache([source], cacheKey);
} catch (error: any) {
} catch (error) {
if (!handleRemoteCacheError(error)) {
throw error;
}
Expand Down
2 changes: 1 addition & 1 deletion src/run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async function installCli(name: tools.PackageName): Promise<string | void> {
);

addPath(path);
} catch (error: any) {
} catch (error) {
tools.handleError(name, error);
}

Expand Down
2 changes: 1 addition & 1 deletion tests/run.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const core = {
addPath: jest.fn(),
getInput: jest.fn(),
group: (message: string, action: () => Promise<any>) => action(),
group: <T>(message: string, action: () => Promise<T>): Promise<T> => action(),
info: jest.fn(),
};
const exec = { exec: jest.fn() };
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"compilerOptions": {
"outDir": "./build",
"rootDir": "./src",
"noImplicitAny": false
"useUnknownInCatchVariables": false
},
"exclude": [
"build",
Expand Down