Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the example in the README to use eas-version #222

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

jonsamp
Copy link
Member

@jonsamp jonsamp commented Jun 14, 2023

I tried out the code in the README and got hung up on the fact that EAS CLI was not installed. I was not installed because the README had an example with expo-version instead of eas-version. This PR updates that key.

Copy link
Member

@byCedric byCedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gentleman-club

@byCedric byCedric merged commit 7bc946c into main Jun 14, 2023
@byCedric byCedric deleted the jon/update-pr-preview-example branch June 14, 2023 21:54
expo-bot pushed a commit that referenced this pull request Nov 24, 2023
## [8.1.0](8.0.0...8.1.0) (2023-11-24)

### New features

* add fingerprint integration ([#231](#231)) ([e6622e0](e6622e0))
* add readme for preview-build and fingerprint action ([#232](#232)) ([acc171b](acc171b)), closes [/github.com//pull/231#pullrequestreview-1628540314](https://github.com/expo//github.com/expo/expo-github-action/pull/231/issues/pullrequestreview-1628540314)
* **preview:** add update manifest permalinks to the output ([#245](#245)) ([331a5ab](331a5ab))

### Bug fixes

* **preview:** allow multiple `app.json` schemes ([#244](#244)) ([42d64cf](42d64cf))

### Code changes

* update error handling to node 20 standards ([#243](#243)) ([65ee055](65ee055))
* update workflows and repository to use Bun ([#241](#241)) ([7f1c170](7f1c170))
* upgrade all actions to run on node 20 ([#242](#242)) ([b3e5355](b3e5355))

### Other chores

* **ci:** update release flow with new service account ([#238](#238)) ([e289d93](e289d93))
* update release workflow actions ([#239](#239)) ([57dcabe](57dcabe))

### Documentation changes

* add link to breaking change pull request ([9e1a8c8](9e1a8c8))
* fix changelog link in readme ([185932d](185932d))
* update example to use `eas-version` ([#222](#222)) ([7bc946c](7bc946c))
@expo-bot
Copy link

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants