Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(preview): add qr-target and use proper QR codes for expo-go and dev-build #247

Merged
merged 10 commits into from
Dec 2, 2023

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Nov 28, 2023

⚠️ Warning This changes the default behavior around QR codes, and in rare cases might be a breaking change. But, since the QR codes are broken as is, we are releasing this as a minor version.

This PR fixes the QR codes for both Expo Go and Dev Client projects.

  • It infers if expo-dev-client is currently used in the project, and if so, it uses the exp+<slug>:// QR code prefix.
  • When using Expo Go, it defaults to the actual EAS Update link itself. This can be opened in Expo Go when not using any custom modules.

You can override this logic by setting the qr-target: expo-go | dev-build.

Troubleshouting

If you run into issues with expo-dev-client QR codes, follow these steps.

  • Make sure the expo-dev-client plugin is added to the app.json plugins list.
  • Make sure your expo-dev-client build can be opened through an exp+<slug>:// deep link. (see QR codes broken when using custom schemes #240)
  • Make sure you have the development build, not a production build. Only development builds can open arbitrary EAS Update links.

Linked issue

See #240

@byCedric byCedric changed the title fix(preview): use app slug to generate proper EAS Update preview feature(preview)!: add qr-target and use proper QR codes for Expo Go and Dev Client projects Nov 28, 2023
@byCedric byCedric force-pushed the @bycedric/preview/fix-qr-codes branch from 85ebe6d to d4168c8 Compare December 2, 2023 13:51
@byCedric byCedric changed the title feature(preview)!: add qr-target and use proper QR codes for Expo Go and Dev Client projects feature(preview)!: add qr-target and use proper QR codes for expo-go and dev-build Dec 2, 2023
@byCedric byCedric force-pushed the @bycedric/preview/fix-qr-codes branch 2 times, most recently from fcf007a to bda94c4 Compare December 2, 2023 13:58
@byCedric byCedric force-pushed the @bycedric/preview/fix-qr-codes branch from bda94c4 to 307c27c Compare December 2, 2023 14:00
@byCedric byCedric changed the title feature(preview)!: add qr-target and use proper QR codes for expo-go and dev-build feature(preview): add qr-target and use proper QR codes for expo-go and dev-build Dec 2, 2023
@byCedric byCedric merged commit 54efbfd into main Dec 2, 2023
14 checks passed
@byCedric byCedric deleted the @bycedric/preview/fix-qr-codes branch December 2, 2023 15:48
expo-bot pushed a commit that referenced this pull request Dec 2, 2023
## [8.2.0](8.1.0...8.2.0) (2023-12-02)

### New features

* **preview:** add `qr-target` and use proper QR codes for `expo-go` and `dev-build` ([#247](#247)) ([54efbfd](54efbfd))

### Documentation changes

* **preview:** clarify the branch and workflow trigger relations ([#246](#246)) ([ccfad6f](ccfad6f))
@expo-bot
Copy link

expo-bot commented Dec 2, 2023

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants