Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

Incorrect QR code data #6

Closed
thebiltheory opened this issue Aug 19, 2021 · 5 comments
Closed

Incorrect QR code data #6

thebiltheory opened this issue Aug 19, 2021 · 5 comments

Comments

@thebiltheory
Copy link

Description of the bug

How would you shortly summarize the issue?
IMG_1800

To Reproduce

What steps did you perform which led to this issue?

name: Expo Review and Preview
on: [pull_request]
jobs:
  preview:
    name: Install and publish
    runs-on: ubuntu-latest
    steps:
      - name: Set up repository
        uses: actions/checkout@v2
      - name: Set up node
        uses: actions/setup-node@v1
        with:
          node-version: 14.x
      - name: Set up Expo
        uses: expo/expo-github-action@v6
        with:
          expo-cache: true
          expo-version: 4.x
          token: ${{ secrets.EXPO_TOKEN }}
      - name: Install dependencies
        run: yarn install
      - name: Publish to expo and create a QR code
        uses: expo/expo-preview-action@v1
        with:
          channel: pr-${{ github.event.number }}
        id: preview

      - name: Comment deployment link
        uses: unsplash/comment-on-pr@master
        env:
          GITHUB_TOKEN: ${{ secrets.EXPO_GH_TOKEN }}
        with:
          msg: >
            Awesome! Your Pull Request Preview App is ready for testing, you can [see it here](https://expo.io/@garaji/garaji-marketplace?release-channel=pr-${{ github.event.number }}).
            <a href="${{ steps.publish.outputs.EXPO_QR_CODE_URL }}"><img src="${{ steps.preview.outputs.EXPO_QR_CODE_URL }}" height="512px" width="512px"></a>
            <br><br>
            ${{ steps.publish.outputs.EXPO_NEW_BUILD_IS_REQUIRED_MESSAGE }}

Expected behavior

What did you expect to have happened?
Open the Expo Go client

Actual behavior

What did it actually result in?
Incorrect data in the QR code

Additional context

Can you further explain the issue? E.g., information about version/environment or screenshots.

@dlombardi
Copy link

Bump. same thing happening for me.

@lucasmotta
Copy link

For me the QR generated actually opens Expo, but it cannot find the actual preview.

@dlombardi
Copy link

This is still occurring. Please any help?

@Fedeorlandau
Copy link

I can reproduce it as well. :(

@tcdavis
Copy link

tcdavis commented Jul 20, 2022

If you encounter this issue, you do not have an application installed on the phone that can handle the scheme you are using in the action.
If you build and install a new development build, it will likely resolve the issue for you. Sorry we don't have a mechanism to display a more transparent error message!

@tcdavis tcdavis closed this as completed Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants