chore: setup expo preview #246
Conversation
This comment has been minimized.
This comment has been minimized.
|
@simoneb there seems to be some issues with the expo action and the QR code is incorrect. See issue here: expo/expo-preview-action#6 I can find the project link in the command line output and that points here: https://expo.dev/@nearform/optic-expo?release-channel=pr-246 However that doesn't seem to be working on my device. |
|
Before we troubleshoot this can you please align it to how it's done in https://github.com/nearform/optic-expo/blob/master/.github/workflows/publish.yml? E.g. the environment handling |
|
App is ready for review, you can see it here. |
There was a problem hiding this comment.
This works but I think we can do better. There is quite a bit of duplication between the existing publish workflow and this new reusable workflow.
They are doing exactly the same thing except for the handling of the release channel. I would suggest that:
- we create a single reusable workflow which does the publishing
- it takes as input the release channel, with the default value being default
- it's fine to always comment on the PR even when the release channel is default
- invoke this reusable workflow both from the publish workflow and from the ci workflow. In the latter case, it will provide a release-channel input with value
pr-${{ github.event.number }}
Minor:
- I prefer removing all the names on the steps, they're usually redundant and unnecessarily clutter the workflow code
- point to specific versions of third party actions instead of master
|
App is ready for review, you can see it here. |
1 similar comment
|
App is ready for review, you can see it here. |
|
I think it's right now and hope it's what you had in mind as far as sharing the expo publishing action. One thing is it's set to use this current branch ( |
|
App is ready for review, you can see it here. |
.github/workflows/cd.yml
Outdated
| @@ -0,0 +1,15 @@ | |||
| name: publish | |||
There was a problem hiding this comment.
let's keep the name consistent with the file name, hence: cd
Co-authored-by: Simone Busoli <[email protected]>
|
App is ready for review, you can see it here. |
|
App is ready for review, you can see it here. |
|
App is ready for review, you can see it here. |
|
I've set this to run on the action from the master branch so it's failing. It'll work once it's merged in. |
Co-authored-by: Simone Busoli <[email protected]>
Co-authored-by: Simone Busoli <[email protected]>
No description provided.