Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios] Add vendored code for lottie-react-native v3 #11586

Merged
merged 2 commits into from
Jan 11, 2021
Merged

[ios] Add vendored code for lottie-react-native v3 #11586

merged 2 commits into from
Jan 11, 2021

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Jan 9, 2021

Why

Followup #11499 and #11488

How

Ran et new-update-vendored-module -m lottie-react-native -p ios and added autolinking for vendored modules

Test Plan

Lottie examples in native-component-list work back again

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2021

Native Component List for this branch is ready

@tsapeta tsapeta mentioned this pull request Jan 10, 2021
Merged
@tsapeta tsapeta marked this pull request as ready for review January 11, 2021 08:23
@tsapeta tsapeta requested a review from ide as a code owner January 11, 2021 08:23
@tsapeta tsapeta requested a review from bbarthec January 11, 2021 08:33
bbarthec
bbarthec approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this one 😊 Many people will be very happy seeing this upgrade 🎉

@tsapeta tsapeta merged commit 6fdef25 into master Jan 11, 2021
@tsapeta tsapeta deleted the @tsapeta/ios/vendor-lottie branch January 11, 2021 11:59
@tsapeta tsapeta mentioned this pull request Feb 16, 2021
Merged
@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarthec bbarthec bbarthec approved these changes

@ide ide Awaiting requested review from ide ide is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsapeta @bbarthec