[permissions] Migrate interface to expo-modules-core #12961
Conversation
tsapeta
force-pushed
the
@tsapeta/remove-permissions-interface
branch
from
4d234d4
to
5d8d5ac
Compare
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #12961 (review)
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #12961 (review)
tsapeta
force-pushed
the
@tsapeta/remove-permissions-interface
branch
from
f4b2b37
to
88d2ac0
Compare
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #12961 (review)
tsapeta
requested review from
bbarthec,
byCedric,
cruzach,
EvanBacon,
ide,
IjzerenHein and
lukmccall
as code owners
tsapeta
force-pushed
the
@tsapeta/remove-permissions-interface
branch
from
88d2ac0
to
839b19a
Compare
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #12961 (review)
tsapeta
force-pushed
the
@tsapeta/remove-permissions-interface
branch
from
839b19a
to
4ebfb1c
Compare
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #12961 (review)
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #12961 (review)
tsapeta
force-pushed
the
@tsapeta/remove-permissions-interface
branch
from
33a1d65
to
3350d8f
Compare
There was a problem hiding this comment.
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.
I've found some issues in your pull request that should be addressed (click on them to expand) 👇
⚠️ Warning: Missing changelog entries
If you made some API or behavioral changes, please add an appropriate entry to the following changelogs:
Generated by ExpoBot 🤖 against 3350d8f
Why
Followup #12718
How
Removed
unimodules-permissions-interfacepackage and replaced its references to the new interface living inexpo-modules-core.Removed unnecessary dependency on this interface in
expo-smsandexpo-sensors.Test Plan
NCL examples of modified packages seem to work as expected
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).