Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-av] Added ability to disable microphone permission #13446

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

EvanBacon
Copy link
Contributor

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 30, 2021
Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review previously left here is no longer valid, jump to the latest one 👉 #13446 (review)

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 30, 2021
Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review previously left here is no longer valid, jump to the latest one 👉 #13446 (review)

Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe to me 👍

@expo-bot expo-bot removed the bot: passed checks ExpoBot has nothing to complain about label Jul 7, 2021
Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them to expand) 👇

⚠️ Suggestions: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider (it's optional) adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 63e67e1

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jul 7, 2021
@EvanBacon EvanBacon merged commit 486d6f4 into master Aug 3, 2021
@EvanBacon EvanBacon deleted the @evanbacon/expo-av/disable-mic-permission branch August 3, 2021 17:47
FelipeACP pushed a commit to FelipeACP/expo that referenced this pull request Sep 18, 2021
* added ability to disable microphone permission

* Update CHANGELOG.md
@ezekiel747
Copy link

Hi, how can this config option be used? Where should i specify it? Thanks in advance.

@ezekiel747
Copy link

I think i found the solution, seems to work.
I'm leaving the instructions here for anyone who may need them.

I've added in app.json under expo -> plugins

    "plugins": [
      ..., //other plugins
      [
        "expo-av",
        { "microphonePermission": false}
      ]

Then rebuild.
This is similar to the docs example, for another lib: https://docs.expo.dev/development/getting-started/#customizing-your-runtime

Another way of supressing this permission can be found here (not sure how safe it is, needs retesting): software-mansion/react-native-reanimated#3021 (comment)

Thank you @EvanBacon & team. God bless you for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants